Handle out of bounds WGS84 coordinates #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geoservice API geometry filters in the WGS84 coordinate system may contain coordinates that lie outside the bounds of the WGS84 extent (e.g., -185, -95). Out of bounds coordinates, particularly latitudes are non-sensical, but certain clients have been known to produce them. This PR constrains any out-of-bounds coordinates to their known limits (e.g., -95 latitude -> -90 latitude).
In addition, the proj4 dependency appears to have a problem with reprojecting WGS84 latitudes -90 and 90 - as of this writing is throws an error. The PR makes a change so that latitudes of -90 or 90 are modified to -89.99999 and -89.99999, respectively. This allow reprojection to proceed as expected.